Opened 9 years ago

Closed 9 years ago

#400 closed enhancement (fixed)

shr_clock should use fso instead of calling directly date

Reported by: misc Owned by: dos
Priority: minor Milestone:
Component: shr-settings Version: SHR-unstable
Keywords: Cc:

Description

There is a comment in shr_setting telling that os.system should be replaced by a dbus request. Here is a patch that does it.

However, my test showed me that the dbus request, while finishing sucessfully, do not change the date at all :

root@nivmizzet ~ $ date ; mdbus -s org.freesmartphone.odeviced "/org/freesmartphone/Device/RealTimeClock/rtc0" org.freesmartphone.Device.RealTimeClock
.SetCurrentTime 1 ; date ;         
Fri Apr 17 03:31:32 CEST 2009
Fri Apr 17 03:31:35 CEST 2009

I will fill a different bug report for this issue.
In the mean time, the patch seems to work fine, according to our old friend "print".

Attachments (1)

0001--use-fso-api-instead-of-calling-directly-date.patch (1.5 KB) - added by misc 9 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 Changed 9 years ago by dos

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.