Opened 9 years ago

Closed 8 years ago

#369 closed defect (fixed)

fix TODO in to shr_gprs.py for storing apn, login and password

Reported by: Pander Owned by: dos
Priority: major Milestone:
Component: shr-settings Version: SHR-unstable
Keywords: Cc:

Description

The default apn, login and password are hardcoded to "internet", "internet" and "internet" This should be easily changeable as is noted as TODO in the source code.

Many GPRS users, use "internet", "" and "" and as a temporary solution, radio buttons could be offered that cover most of the default credentials. See them here:

http://wiki.openmoko.org/wiki/Manually_using_GPRS#Some_APN_names_for_reference

Important to gain a biger audience for SHR, is that users, even if they are advanced, never have to go inside source code to make their settings. Fixing this will be one step further towards this.

Change History (5)

comment:1 Changed 9 years ago by KaZeR

Interested in this one too.

comment:2 Changed 9 years ago by dos

I don't understand - GPRS apn, login and pass are easily changeable - simply click on label and type it. They aren't stored anywhere, so on every SHR Settings start you have to type it again, or change it in source code. Implementing storing it's only enhancement, it's not necessary to play with code.

Of course storing will be there in near future. But it's absolutely not major issue :P

comment:3 Changed 9 years ago by dos

  • Owner changed from ainulindale to dos
  • Status changed from new to assigned

comment:4 Changed 9 years ago by dos

  • Status changed from assigned to accepted

comment:5 Changed 8 years ago by dos

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed by Toaster` :)

Note: See TracTickets for help on using tickets.