Opened 10 years ago

Closed 7 years ago

#1020 closed defect (worksforme)

Can't enter data into fields to add new contact

Reported by: njw Owned by: TAsn
Priority: critical Milestone:
Component: SHR Image Version: SHR-core
Keywords: Cc:

Description

If I open up contacts, and press new, I'm presented with 2 blank
fields, Name and Phone. All well and good. I expected that when I
press them a keyboard would appear and I'd be able to enter the
appropriate information. But no such luck. No keyboard appears, and
if I open one by pressing the top bar then 'alpha', no text entered
appears anywhere.

Attachments (1)

0001-Fix-edit-button-for-contact-fields.patch (1.6 KB) - added by jeepingben 7 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 follow-up: Changed 10 years ago by njw

Found out more. It does work (press edit, then tap the field), but only if the field isn't selected until the edit button is pressed. So if it's already highlighted, and then edit is pressed, pressing the field again doesn't result in an editable field.

comment:2 in reply to: ↑ 1 Changed 10 years ago by TAsn

  • Owner changed from ainulindale to TAsn
  • Status changed from new to accepted

Replying to njw:

Found out more. It does work (press edit, then tap the field), but only if the field isn't selected until the edit button is pressed. So if it's already highlighted, and then edit is pressed, pressing the field again doesn't result in an editable field.

Yeah, exactly what I said in ML.

comment:3 Changed 10 years ago by Heinervdm

  • Milestone set to MS1

comment:4 Changed 10 years ago by notelvis

If you click on the pencil thing, so it turns into a trashcan, then click on the field name so it pops up the list of fields, then click on cancel, THEN you can click on the text entry area and enter a name. Repeat that whole dance and you can enter a phone number. Pressing save will successfully save it.

But if you try to add a second contact, the New button will do nothing...

comment:5 Changed 10 years ago by mrmoku

  • Resolution set to fixed in unstable
  • Status changed from accepted to closed

fixed in SHR-U with libphone-ui-shr rev 8d5fe07a49d4f42532408e2c31a85e2b601a3f23
Update is already in the feed.

comment:6 Changed 9 years ago by jama

  • Resolution fixed in unstable deleted
  • Status changed from closed to reopened

comment:7 Changed 9 years ago by jama

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 9 years ago by mywave

  • Cc mywave added

First time I tried to use the application I hit the same "bug", which isn't a bug in the software itself, but rather the design. I actually had to search for bug reports in order to start using one of the most basic and most important applications on a phone.. the contact list.

WOW. This bug actually even has several duplicates without anybody writing anything about perhaps the UI should change to be more user-friendly and intuitive.

1: If the field is not in edit mode it should not be possible to mark it (make it orange)
2: If the field is not in edit mode, the button for changing the field type should not be clickable
3: The icon for going into edit mode should perhaps be changed somewhat. Since it became a garbage-bin when pressed, I assumed it was an gargabe-bin moved a bit out of the frame. For instance, change the edit-icon so that it actually looks more like a pen (add a 45 degree angle on it), or the let the field go into edit mode when selected, and have a global button on the top for enabling editing at all.

Just my random toughts...

comment:9 Changed 8 years ago by morphis

  • Milestone MS1 deleted

Milestone MS1 deleted

comment:10 Changed 7 years ago by Thamos0815

  • Cc mywave removed
  • Priority changed from major to critical
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from SHR-testing to SHR-core

Reappearing again. i can't edit any fields, because the edit button doesn't work at all.

comment:11 Changed 7 years ago by Thamos0815

Version is staging 105

Changed 7 years ago by jeepingben

comment:12 Changed 7 years ago by jeepingben

It looks like the callback wasn't being properly added for the edit icon. Elm_icon.h says not to expect callbacks to work for much longer so I tried switching it to elm_image. That didn't work either. I've attached a patch that replaces the icon with a button that uses the same icon. This isn't as pretty, but it works.

I couldn't figure out when the delete button was supposed to be visible. I never see it.

comment:13 Changed 7 years ago by Thamos0815

  • Resolution set to worksforme
  • Status changed from reopened to closed

in latest-107 (now core) this works for me and would say its pretty enough. I close this bug therefor.

Note: See TracTickets for help on using tickets.